Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new lastread filter #1091

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

new lastread filter #1091

wants to merge 1 commit into from

Conversation

niol
Copy link
Collaborator

@niol niol commented Feb 17, 2019

Introduces a new filter: last read items, that is items ordered by the last time they were read, excluding the items that were skipped using 'Mark Visible Read'.

Introduces a new filter: last read items, that is items ordered by the last
time they were read, excluding the items that were skipped using 'Mark
Visible Read'.
@jtojnar
Copy link
Member

jtojnar commented Feb 17, 2019

Do we want filters to change the order of items? And will it not be confusing that marking items individually as read behaves differently from using the green button?

@niol
Copy link
Collaborator Author

niol commented Feb 18, 2019

I've found it very useful for me to have some kind of reading history distinguishing between items I opened and items I just marked as read without reading. This makes it possible to quickly find an article the you read a couple hours before, something that is more difficult without this.
Also, this opens the door to having stats of how much article you read regarding how much you discard (not implemented here).

@jtojnar
Copy link
Member

jtojnar commented Feb 18, 2019

One thing I do not like on this is that the skipped status is a separate column, even though it is mutually exclusive with the unread flag. Maybe it would make more sense to replace both columns with single status column that would be of type enum(new, read, dismissed).

@jtojnar
Copy link
Member

jtojnar commented Feb 18, 2019

Or even simpler, we could track readtime and readtime == null && unread == 0 would mean the item was dismissed (though this is maybe too implicit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants