Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'read up to here' button on entries in articleList, moved open utton to top of toolbar (was to close to readuptohere) #1086

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

otdftr
Copy link

@otdftr otdftr commented Feb 3, 2019

a feature I found very useful in NEWSIFY: mark read "up to here"
hacked into my v2.18 installation of Selfoss and wanted to share it as a suggested feature

@niol
Copy link
Collaborator

niol commented Feb 4, 2019

This is a good idea. This may be an answer to #1021 .
As for the code, I would suggest not including history comments in the source and less code duplication (creating selfoss.dbOnline.mark(ids) and selfoss.ui.mark(ids) may help though handling the possible rollback may be tricky). Hopefully I can fix that later if this get accepted.

@otdftr
Copy link
Author

otdftr commented Feb 4, 2019 via email

@jtojnar
Copy link
Member

jtojnar commented Jul 13, 2020

Sorry, forgot to reply here.

I like this idea and occasionally wanted this myself but I wanted to avoid cluttering the interface with more buttons so until we come up with a way to let users customize the buttons (perhaps extend the share config to other buttons as well) I would suggest users to add the snippet to their user.js file and am concerned about the code duplication.

I think selfoss.dbOnline.mark(ids) would be very useful since the markVisibleRead is already beyond tolerable complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants