Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multiple File Uploads in a row put all the files at the beginning #2637

Conversation

gupta-piyush19
Copy link
Contributor

What does this PR do?

  • Multiple File Uploads in a row put all the files at the beginning
  • Adds uniqueId prop to FileInput component

Fixes #2596

fileupload-fix.mp4

How should this be tested?

  • Create a survey with a few file upload-type questions(especially enable multi-file upload for a few)
  • All questions should keep track of the uploaded files into it

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 4:21am
formbricks-docs ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 4:21am

Copy link
Contributor

github-actions bot commented May 16, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@github-actions github-actions bot added the bug Something isn't working label May 16, 2024
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gupta-piyush19 thank you :-) looks great; only a small naming concern:

@@ -25,6 +26,7 @@ export const FileInput = ({
fileUrls,
maxSizeInMB,
allowMultipleFiles,
uniqueId = "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is changing the htmlFor field wouldn't it maybe more consistent to also name it htmlFor in the props to be consistent and not let devs wonder what the uniqueId is used for.

…2596-bug-multiple-file-uploads-in-a-row-put-all-the-files-at-the-beginning
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gupta-piyush19 thanks for making the changes :-)

@mattinannt mattinannt added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit e539ac8 May 17, 2024
12 checks passed
@mattinannt mattinannt deleted the 2596-bug-multiple-file-uploads-in-a-row-put-all-the-files-at-the-beginning branch May 17, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Multiple File Uploads in a row put all the files at the beginning
2 participants