feat: recall from hidden fields and attributes

[Dhruwang]

What does this PR do?

Fixes #2353 #2327

• Now we also allow recalling from hidden fields and attributes
• Initially it was mainly focused on question, so we used namings like recallQuestion, selectRecallQuestion but now its more generic, so now we use recallItem, selectRecallItems
• Breaks single response card into smaller components

Attributes

Hidden Fields

Also made the recall object more expandable to support other fields in future

How should this be tested?

For link surveys -> recall from questions and hidden fields is allowed
Fo app surveys -> recall from questions and attributes is allowed

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues
• First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)	Visit Preview		May 24, 2024 5:29am
formbricks-docs	⬜️ Ignored (Inspect)	Visit Preview		May 24, 2024 5:29am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[jobenjada]

hey @Dhruwang

thanks a lot, love how you always crank out a bunch of cool improvements out on a given day :D 🚀

Here's what I noticed:

1. If the @ is the first character in the input, I cannot select the option:

---

2. We need to make clear that the second input field is the placeholder for the second recall item:

Easiest would be to add a placeholder text with the recall item label so the hiddenField id or the question.

---

3. The recall of attributes does not seem to work for me. I've recorded a video to show how I tried:

bug_attribute-not-working.mp4

---

4. Kombobox / Search bar for dropdown: some users have thousands of attributes. It would make sense to add the same combobox that we're now using in the Logic Editor:

see here: #2584

---

Did you try your implementation with each question types? I normally find bugs when I do that 😉

---

Other than that, it works great :) Thanks!

[Dhruwang]

Hey @jobenjada , have updated the PR ! 😊

Fallback input with placeholders

Searchable dropdown

Also tested the recall from attributes and it seems to work fine 🤔

Screen-Recording-2024-05-13-at-12.27.47.PM.mp4

In the video that you provided, did you miss the survey saving ?

[jobenjada]

Hey Dru!

Looks good :) Here's my feedback:

1. Keyboard usability

With the search bar, we lost keyboard usability:

Pls make sure that Arrow down lets people select one of the fields. Similarly, if they go back up with the keys they should hop back into the Search bar once they reach the top of the list.

---

2. UI changes in response card

As laid out in Slack

---

Please ping me once you've reworked the attribute logic, then I'll test it.

Thanks!

[jobenjada]

looks and works great :) @mattinannt over to you 🤸

[jobenjada]

looks great! :)