Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modified google sheet integration and minor refactors in other integrations #2572

Merged
merged 9 commits into from May 23, 2024

Conversation

Dhruwang
Copy link
Contributor

@Dhruwang Dhruwang commented May 3, 2024

What does this PR do?

  1. Originally, within the Google Sheets integration, users were presented with a selection of accessible spreadsheets. This process also required access to the sensitive "drive" scope. However, in alignment with the new user experience (UX), individuals are now prompted to input the URL of their spreadsheet to establish the Google Sheet link.
  2. Across Google Sheets, Airtable, Slack, and Notion integrations, we employed the Connect.tsx component uniformly. Consequently, we developed a reusable component for this purpose within the packages/ui directory.
  3. Various minor refinements.
Screen-Recording-2024-05-03-at-3.04.04.PM.mp4

Fixes https://github.com/formbricks/internal/issues/132

How should this be tested?

Test google sheet integraton

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 9:15am
formbricks-docs ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 9:15am

Copy link
Contributor

github-actions bot commented May 3, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang sorry for the late review :-) Code looks great :-) There are only two small questions I added below.
Also can you please check the docs page ( https://formbricks.com/docs/self-hosting/integrations#google-sheets ) if changes needs to be made here? :-)

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thanks for making the changes :-) :-) Let's merge this!

@mattinannt mattinannt added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@mattinannt mattinannt added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 12a606a May 23, 2024
12 checks passed
@mattinannt mattinannt deleted the gs-fix branch May 23, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants