feat: Enable Prefilling of several values

[gupta-piyush19]

What does this PR do?

Enables Prefilling of several values

Fixes
https://github.com/formbricks/internal/issues/73
#2433

multi-question-prefill.mp4

How should this be tested?

• Create a survey with more than 1 question, try to prefil multiple question by providing id=value in the query params.

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)	Visit Preview		Apr 29, 2024 8:50am
formbricks-com	⬜️ Ignored (Inspect)	Visit Preview		Apr 29, 2024 8:50am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[jobenjada]

Hey! Works well so far :) A few questions:

1. Please update the Prefilling docs in the link survye section with the changes. Add a section where you explain the format needed for each question type as well as potential edge cases, what happens when the validation doesn't work and add an example for all question types which can be prefilled.
2. Currently, it's not possible to get the initial UX of clicking on an answer in an email which then gets prefilled and the question is skipped. My idea was to do use logic jumps to still enable this UX, even if not by default (see image). Is this possible without being too hacky? So essentially: Don't skip prefilled values unless a logic jump says so?
3. Not sure if it was part of the ticket but is it possible to introduce another link parameter skipPrefill which when set to true skips prefilled questions? How hacky would it be?

Thanks!

[gupta-piyush19]

Thanks, @jobenjada, for the review.
As per your suggestions,

1. I've updated the docs and added examples for all the questions that can be prefilled.
2. We're keeping the logic very simple in this PR, just to show the prefilled value to the user. This could create messed-up logic if done with startAt functionality.
3. To support skipPrefill, we would still need two different urls, one with skipPrefill query params and the other without them. If we've got to create two different links anyway, it'd be better to just remove the prefiling parameters in the second one instead of adding one extra param.

Hey! Works well so far :) A few questions:

1. Please update the Prefilling docs in the link survye section with the changes. Add a section where you explain the format needed for each question type as well as potential edge cases, what happens when the validation doesn't work and add an example for all question types which can be prefilled.
2. Currently, it's not possible to get the initial UX of clicking on an answer in an email which then gets prefilled and the question is skipped. My idea was to do use logic jumps to still enable this UX, even if not by default (see image). Is this possible without being too hacky? So essentially: Don't skip prefilled values unless a logic jump says so?
3. Not sure if it was part of the ticket but is it possible to introduce another link parameter skipPrefill which when set to true skips prefilled questions? How hacky would it be?

Thanks!

[jobenjada]

Hey Piyush!

Works great, good job until here!

As you mentioned, once you bring startAt to the party, things get messy. Let's have a chat re this tomorrow and then merge this 💪

In the meanwhile: if related to this, pls look into the failed E2E test

Thanks!

[jobenjada]

Hey! A few bugs:

The first question gets a "back" button on prefill:

And the second question doesn't?

That should be it :)

[jobenjada]

pls see comment

[gupta-piyush19]

@jobenjada Thanks for testing the feature. I've pushed the fix for the issues.

prefiling.mp4

[pandeymangg]

Thanks for the PR @gupta-piyush19 😊 looks great!
I just found this bug while testing, could you please take a look at it 🙏

Screen.Recording.2024-04-29.at.12.04.06.PM.mov

[pandeymangg]

LGTM! 🚀