Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SixLabors.ImageSharp from 3.1.3 to 3.1.4 in /Platform/FO-DICOM.Imaging.ImageSharp #1779

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 30, 2024

Bumps SixLabors.ImageSharp from 3.1.3 to 3.1.4.

Release notes

Sourced from SixLabors.ImageSharp's releases.

v3.1.4

What's Changed

Full Changelog: SixLabors/ImageSharp@v3.1.3...v3.1.4

Commits
  • da5f09a Merge pull request #2716 from SixLabors/js/clear-buffers
  • b6b08ac Merge pull request #2706 from SixLabors/af/memlimit-01
  • 572366e test allocation limits
  • d1cc651 fix BmpDecoder_ThrowsException_Issue2696
  • 4a26acb Merge pull request #2718 from SixLabors/js/check-palette-index
  • fb64b33 Clamp read palette indices.
  • 26d44ef Clear pixel buffers on decode.
  • da49788 Revert additional changes
  • eec9718 Merge branch 'release/3.1.x' into af/memlimit-01
  • 8e6532a Merge pull request #2713 from SpaceCheetah/FixPngBackport
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [SixLabors.ImageSharp](https://github.com/SixLabors/ImageSharp) from 3.1.3 to 3.1.4.
- [Release notes](https://github.com/SixLabors/ImageSharp/releases)
- [Commits](SixLabors/ImageSharp@v3.1.3...v3.1.4)

---
updated-dependencies:
- dependency-name: SixLabors.ImageSharp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 30, 2024
@jaime-olivares
Copy link
Contributor

jaime-olivares commented May 15, 2024

We are receiving several reports of customers regarding images not properly rendered.
It seems ImageSharp 3.x.x solves those issues.
Please consider to update the library as soon as possible.

@gofal
Copy link
Contributor

gofal commented May 15, 2024

Because of changes in License, we have 2 packages: fo-dicom.Imaging.ImageSharp, which references ImageSharp 3.* and which has limited License, and fo-dicom.Imaging.ImageSharp.NetStanard, which still references ImageSharp 2.* and is completely free.
So the version 2 of ImageSharp has a bug? Or do you mean, ImageSharp 3.1.3 has a bug and should be updated to 3.1.4?

@jaime-olivares
Copy link
Contributor

jaime-olivares commented May 16, 2024

As far as I can see, fo-dicom 5 uses ImageSharp for production (master branch: https://github.com/fo-dicom/fo-dicom/blob/master/Platform/FO-DICOM.Imaging.ImageSharp/FO-DICOM.Imaging.ImageSharp.csproj).
The versions you are referring to (2.x and 3.x) are in the development branch.

Plus, we have observed version 3.x solves some issues

@gofal gofal merged commit f8199fe into development May 18, 2024
4 checks passed
@gofal gofal deleted the dependabot/nuget/Platform/FO-DICOM.Imaging.ImageSharp/SixLabors.ImageSharp-3.1.4 branch May 18, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants