Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly Order FilmBox Images By Name #1738

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

vela1606
Copy link

@vela1606 vela1606 commented Mar 1, 2024

Fixes #1737

Checklist

  • The pull request branch is in sync with the latest commit on the fo-dicom/development branch
  • [n/a] I have updated API documentation
  • [n/a] I have included unit tests
  • [n/a] I have updated the change log
  • [n/a] I am listed in the CONTRIBUTORS file

Changes proposed in this pull request:

  • Explicitly Alphabetically Order FilmBox Images

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.46%. Comparing base (e01ca09) to head (204f7fe).

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1738      +/-   ##
===============================================
+ Coverage        76.42%   76.46%   +0.04%     
===============================================
  Files              275      275              
  Lines            25401    25401              
  Branches          3043     3043              
===============================================
+ Hits             19412    19423      +11     
+ Misses            5061     5050      -11     
  Partials           928      928              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gofal
Copy link
Contributor

gofal commented Mar 13, 2024

Thanks for the PR, @vela1606
Sorting the images by filename is far better than loading them in any random order that the operating system delivers.
But still it might not be right. Wouldn't it be better, first to load all the imageboxes, and then sort them by actual DICOM-tags like SeriesInstanceUID, InstanceNumber or AcquisitoinDateTime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print SCU layout Images not rendering in the correct order
2 participants