Propagate custom_info Dict through agent Resource #2426
+128
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also flyteorg/flyte#5391
Tracking issue
Why are the changes needed?
The agent defines a Resource return type with values:
These are all a part of the underlying protobuf contract defined in
flyteidl.
However, the message field custom_info from the protobuf is not here
google.protobuf.Struct custom_info
https://github.com/flyteorg/flyte/blob/519080b6e4e53fc0e216b5715ad9b5b5270f35c0/flyteidl/protos/flyteidl/admin/agent.proto#L140
This field was added in Agents protocol refactor flyte#4874
but never made it into the corresponding flytekit PR
Add SyncAgentBase #2146
It's useful for agents to return additional metadata about the job,
and it looks like custom_info is the intended location
Make a minor refactor to how the agent responds to requests that
return Resource by implementing to_flyte_idl / from_flyte_idl
directly
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link