Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting #853 #864

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reverting #853 #864

wants to merge 1 commit into from

Conversation

jsonporter
Copy link
Contributor

This PR reverts a previous commit #853 as it was a breaking change for non localhost use-cases.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Jason Porter <[email protected]>
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.74%. Comparing base (7e0f2bd) to head (e64c5e0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #864   +/-   ##
=======================================
  Coverage   54.74%   54.74%           
=======================================
  Files         578      578           
  Lines       15153    15153           
  Branches     2767     2767           
=======================================
  Hits         8296     8296           
  Misses       6857     6857           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MortalHappiness MortalHappiness mentioned this pull request Apr 19, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant