fix: Broken breadcrumbs when using custom BASE_URL #861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Typo – causes breadcrumbs to not appear in flyteconsole. To fix, use BASE_URL not BASE_PATH.
Type
Are all requirements met?
Complete description
Missing breadcrumbs for custom BASE_URL like
/custom-base/console
Expectation: breadcrumbs are present for custom BASE_URL Flyte instance.
This happens because when
BASE_PATH
is used instead ofBASE_URL
, the logic that generates the breadcrumbs atbreadcrumbRegistry.breadcrumbBuilder
ends up using the wrongBASE_URL
value (this starts frommakeUrlSegments
). This causes it to parse the window location incorrectly, and the resulting generated breadcrumbs is missing the expected entries.Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/