This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Make list execution transformer configurable #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add configuration in flyte admin to control the behavior of the list execution transformer with regard to error message trimming.
Type
Are all requirements met?
Complete description
A hardcoded value of
trimmedErrMessageLen
is used to limit the error message shown in the workflow execution list. The current value is too small that the error message in the list execution page is not informative. Users must go to the corresponding execution details to get the entire error message even for a short error message.This PR add configuration in flyte admin to control whether the error message truncation is enabled and the maximum message length when truncation is enabled. The default is to truncate error messages for list execution API with a maximum error message length of 10240 so that most error messages can be shown properly.
Screen.Recording.2023-05-04.at.4.15.39.PM.mov
Follow-up issue
NA