Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken mermaid diagrams #5498

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix broken mermaid diagrams #5498

merged 1 commit into from
Jun 21, 2024

Conversation

cosmicBboy
Copy link
Contributor

Tracking issue

Closes #4864

Why are the changes needed?

Update the mermaid_init_js configuration to initialize mermaid on page load.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Niels Bantilan <[email protected]>
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.00%. Comparing base (c10346d) to head (862b882).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5498      +/-   ##
==========================================
- Coverage   61.01%   61.00%   -0.01%     
==========================================
  Files         794      794              
  Lines       51441    51441              
==========================================
- Hits        31388    31384       -4     
- Misses      17161    17165       +4     
  Partials     2892     2892              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.73% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.03% <ø> (-0.06%) ⬇️
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.30% <ø> (ø)
unittests-flytestdlib 65.80% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmicBboy
Copy link
Contributor Author

@neverett @davidmirror-ops can confirm that mermaid diagrams build properly with the changes in this PR: https://flyte--5498.org.readthedocs.build/en/5498/deployment/configuration/auth_appendix.html
image

@neverett
Copy link
Contributor

Nice! That's a lot simpler.

@davidmirror-ops
Copy link
Contributor

Thank you!

@davidmirror-ops davidmirror-ops merged commit 4cb1473 into master Jun 21, 2024
50 checks passed
@davidmirror-ops davidmirror-ops deleted the fix-mermaid branch June 21, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Mermaid diagrams not rendering
3 participants