Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monorepo] Move flytectl gh workflows to monorepo #5354

Merged
merged 5 commits into from May 15, 2024

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented May 11, 2024

Why are the changes needed?

We need to be able to release flytectl from the monorepo, this includes the CI checks used to validate the changes.

What changes were proposed in this pull request?

This PR adds the validation CI tests to run at regular PR time and also a specific gh workflow that will watch for tags of a specific format to run the actual flytectl release.

Notice that we moved to goreleaser-pro as the driver, this simplifies the process of releasing from a monorepo immensely (you just have to look the changes needed in flytectl/.goreleaser.yml).

The release process for flytectl will involve creating a tag with a specific format, e.g. in order to release version 1.2.3 of the flytectl we should push a tag like flytectl/v1.2.3. Notice that flytectl is going to be versioned separately from the backend components.

How was this patch tested?

I used https://github.com/nektos/act to run this github job locally.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.09%. Comparing base (ee6037b) to head (79458cd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5354      +/-   ##
==========================================
+ Coverage   60.62%   61.09%   +0.47%     
==========================================
  Files         776      794      +18     
  Lines       49918    51213    +1295     
==========================================
+ Hits        30262    31289    +1027     
- Misses      16839    17043     +204     
- Partials     2817     2881      +64     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.86% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.30% <ø> (ø)
unittests-flyteidl 79.30% <ø> (?)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario changed the title [monorepo] Add goreleaser dry-run job for flytectl [monorepo] Move flytectl gh workflows to monorepo May 13, 2024
@eapolinario eapolinario merged commit 4dd5f3c into master May 15, 2024
50 checks passed
@eapolinario eapolinario deleted the add-gh-wf-flytectl-release branch May 15, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants