Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android/build.gradle template: merge subprojects {} blocks together #147868

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bartekpacia
Copy link
Member

Seeing if subprojects {} can be merged.

See also:

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 6, 2024
@bartekpacia bartekpacia marked this pull request as ready for review May 6, 2024 17:08
This reverts commit 67e660d.
@bartekpacia bartekpacia marked this pull request as draft May 6, 2024 17:09
@AbdeMohlbi
Copy link

@bartekpacia
If u could add this to the template to hit two in a row here

@bartekpacia
Copy link
Member Author

@AbdeMohlbi Right now I'm pretty confused, because this commit did not cause this test to fail.

@AbdeMohlbi
Copy link

AbdeMohlbi commented May 6, 2024

I see even if i don't quite understand how tests works in this kind things can u try to run the test localy or smth i dunno ?sorry if i kept u busy from ur work

@bartekpacia
Copy link
Member Author

I tried, but the results were non-deterministic. Gonna try again soon.

@AbdeMohlbi
Copy link

believe me if i could help i would throw a hand but i'm not capable of yet but soon i will , stay safe mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants