Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test material text field example #147864

Merged
merged 6 commits into from May 14, 2024
Merged

test material text field example #147864

merged 6 commits into from May 14, 2024
+73 −2

Conversation

NobodyForNothing
Copy link
Contributor

Adds simple tests to the last two TextField examples as part of fixing #130459.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 6, 2024
bleroux
bleroux approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small nits.
Thanks for your contribution!

examples/api/test/material/text_field/text_field.1_test.dart Outdated Show resolved Hide resolved
examples/api/test/material/text_field/text_field.2_test.dart Outdated Show resolved Hide resolved
bleroux
bleroux requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small formatting issues.

examples/api/test/material/text_field/text_field.2_test.dart Outdated Show resolved Hide resolved
examples/api/test/material/text_field/text_field.2_test.dart Outdated Show resolved Hide resolved
bleroux
bleroux approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again for this great addition. 🙏

@justinmc justinmc requested a review from victorsanni May 9, 2024 22:07
@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2024
@auto-submit auto-submit bot merged commit 4ecc1b0 into flutter:master May 14, 2024
138 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2024
@engine-flutter-autoroll
4ecc1b092 test material text field example (flutter/flutter#147864)
4b544f4
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 15, 2024
@engine-flutter-autoroll
Roll Flutter from d2da1b280b51 to 39651e84ea12 (18 revisions) (#6738)
87a02e3 
flutter/flutter@d2da1b2...39651e8

2024-05-15 [email protected] Roll Flutter Engine from d35a1a603c80 to bf1c6da0dd31 (1 revision) (flutter/flutter#148369)
2024-05-15 [email protected] Roll Flutter Engine from 55c62ff82c7e to d35a1a603c80 (4 revisions) (flutter/flutter#148367)
2024-05-15 [email protected] Roll Flutter Engine from a1d930a3a84d to 55c62ff82c7e (3 revisions) (flutter/flutter#148365)
2024-05-14 [email protected] Roll Flutter Engine from dfb5871260a6 to a1d930a3a84d (2 revisions) (flutter/flutter#148360)
2024-05-14 [email protected] Roll Flutter Engine from 1b508a071c96 to dfb5871260a6 (1 revision) (flutter/flutter#148356)
2024-05-14 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.3.1 to 4.4.0 (flutter/flutter#148355)
2024-05-14 [email protected] Fix memory leaks in `SnackBar` (flutter/flutter#147212)
2024-05-14 [email protected] Fix memory leaks in open upwards page transition (flutter/flutter#148046)
2024-05-14 [email protected] Fixes semantics ordering when there are multiple TextFields with prefâ�¦ (flutter/flutter#148267)
2024-05-14 [email protected] Roll Flutter Engine from ae9ff69a0840 to 1b508a071c96 (2 revisions) (flutter/flutter#148351)
2024-05-14 [email protected] Add missing InputDecorator.hintText tests (flutter/flutter#148113)
2024-05-14 [email protected] Fix abi key for local golden file testing (flutter/flutter#148072)
2024-05-14 [email protected] Maintain the same layout constraints for item in the ReorderableList during dragging as before dragging. (flutter/flutter#147863)
2024-05-14 [email protected] test material text field example (flutter/flutter#147864)
2024-05-14 [email protected] Move toggleable to widget layer (flutter/flutter#148272)
2024-05-14 [email protected] Roll Flutter Engine from 08b44d906fab to ae9ff69a0840 (1 revision) (flutter/flutter#148341)
2024-05-14 [email protected] add another print trace to runInView (flutter/flutter#148337)
2024-05-14 [email protected] Roll Flutter Engine from 7bf865774d06 to 08b44d906fab (4 revisions) (flutter/flutter#148338)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Piinks Piinks mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleroux bleroux bleroux approved these changes

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@victorsanni victorsanni Awaiting requested review from victorsanni

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NobodyForNothing @bleroux @Renzo-Olivares