Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain the same layout constraints for item in the ReorderableList during dragging as before dragging. #147863

Merged
merged 2 commits into from May 14, 2024

Conversation

yiiim
Copy link
Member

@yiiim yiiim commented May 6, 2024

Fixes #147419

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label May 6, 2024
@yiiim yiiim requested a review from Piinks May 6, 2024 15:13
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! Thanks @yiiim, LGTM!

@Piinks Piinks added f: scrolling Viewports, list views, slivers, etc. a: layout SystemChrome and Framework's Layout Issues autosubmit Merge PR when tree becomes green via auto submit App labels May 14, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2024
Copy link
Contributor

auto-submit bot commented May 14, 2024

auto label is removed for flutter/flutter/147863, due to - The status or check suite Linux web_long_running_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2024
@auto-submit auto-submit bot merged commit e2ef38d into flutter:master May 14, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 15, 2024
flutter/flutter@d2da1b2...39651e8

2024-05-15 [email protected] Roll Flutter Engine from d35a1a603c80 to bf1c6da0dd31 (1 revision) (flutter/flutter#148369)
2024-05-15 [email protected] Roll Flutter Engine from 55c62ff82c7e to d35a1a603c80 (4 revisions) (flutter/flutter#148367)
2024-05-15 [email protected] Roll Flutter Engine from a1d930a3a84d to 55c62ff82c7e (3 revisions) (flutter/flutter#148365)
2024-05-14 [email protected] Roll Flutter Engine from dfb5871260a6 to a1d930a3a84d (2 revisions) (flutter/flutter#148360)
2024-05-14 [email protected] Roll Flutter Engine from 1b508a071c96 to dfb5871260a6 (1 revision) (flutter/flutter#148356)
2024-05-14 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.3.1 to 4.4.0 (flutter/flutter#148355)
2024-05-14 [email protected] Fix memory leaks in `SnackBar` (flutter/flutter#147212)
2024-05-14 [email protected] Fix memory leaks in open upwards page transition (flutter/flutter#148046)
2024-05-14 [email protected] Fixes semantics ordering when there are multiple TextFields with prefâ�¦ (flutter/flutter#148267)
2024-05-14 [email protected] Roll Flutter Engine from ae9ff69a0840 to 1b508a071c96 (2 revisions) (flutter/flutter#148351)
2024-05-14 [email protected] Add missing InputDecorator.hintText tests (flutter/flutter#148113)
2024-05-14 [email protected] Fix abi key for local golden file testing (flutter/flutter#148072)
2024-05-14 [email protected] Maintain the same layout constraints for item in the ReorderableList during dragging as before dragging. (flutter/flutter#147863)
2024-05-14 [email protected] test material text field example (flutter/flutter#147864)
2024-05-14 [email protected] Move toggleable to widget layer (flutter/flutter#148272)
2024-05-14 [email protected] Roll Flutter Engine from 08b44d906fab to ae9ff69a0840 (1 revision) (flutter/flutter#148341)
2024-05-14 [email protected] add another print trace to runInView (flutter/flutter#148337)
2024-05-14 [email protected] Roll Flutter Engine from 7bf865774d06 to 08b44d906fab (4 revisions) (flutter/flutter#148338)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: layout SystemChrome and Framework's Layout Issues autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Padding changes while dragging ReorderableListView on web and desktop
2 participants