Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for shared_app_data.#.dart API examples. #147830

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add tests for shared_app_data.#.dart API examples. #147830

wants to merge 7 commits into from
+245 −44

Conversation

ksokolovskyi
Copy link
Contributor

This PR contributes to #130459

Description

  • Updates examples/api/lib/widgets/shared_app_data/shared_app_data.0.dart to meet latest API examples structure
  • Updates examples/api/lib/widgets/shared_app_data/shared_app_data.1.dart to meet latest API examples structure
  • Adds tests for examples/api/lib/widgets/shared_app_data/shared_app_data.0.dart
  • Adds tests for examples/api/lib/widgets/shared_app_data/shared_app_data.1.dart

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 4, 2024
@ksokolovskyi ksokolovskyi force-pushed the add-shared-app-data-example-tests branch from ba32cb6 to c7b493b Compare May 8, 2024 15:24
@ksokolovskyi
Copy link
Contributor Author

@bleroux could you please look at this PR when you have time?

bleroux
bleroux approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this contribution. Taha and I are attending Google I/O this week so we will probably catch up on pending reviews next week.

examples/api/lib/widgets/shared_app_data/shared_app_data.0.dart Outdated
context,
'bar',
'BAR $_barVersion',
); // no need to call setState()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor: consider capitalizing the first letter and adding a final dot.
Same on line 62.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bleroux thanks for the review and the information. Have a great time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleroux bleroux bleroux approved these changes

@TahaTesser TahaTesser Awaiting requested review from TahaTesser

Assignees
No one assigned
Labels
d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksokolovskyi @bleroux