Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks in context menu #147822

Conversation

ValentinVignal
Copy link
Contributor

Part of #141198

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ValentinVignal
Copy link
Contributor Author

cc @polina-c

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels May 4, 2024
@ValentinVignal
Copy link
Contributor Author

I couldn't enable the leak tracking in some tests as they would fail because of CupertinoPageTransition and CupertinoFullscreenDialogTransition. It needs #146999 to be merged too

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label May 5, 2024
@polina-c
Copy link
Contributor

polina-c commented May 5, 2024

Thanks. Options are:

  1. Wait for Fix janks and memory leaks in CupertinoPageTransition and CupertinoFullscreenDialogTransition #146999 to merge
  2. Create a test that will test cover your change
  3. Do what bot suggests

@ValentinVignal
Copy link
Contributor Author

Let's see if #146999 can get merged first

If not, I'll try to write a test

@ValentinVignal ValentinVignal force-pushed the flutter/leak-tracking/Fix-memory-leaks-in-context-menu branch from 47d853c to d4e72ec Compare May 8, 2024 03:42
@ValentinVignal
Copy link
Contributor Author

@polina-c I modified the tests in test: Update the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants