[Impeller] leave glyph atlas in transfer dst to improve vulkan throughput. #52908
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
force-pushed
the
batch_render_glyphs_sometimes
branch
from
b167bca
to
c64d201
Compare
| @@ -96,6 +101,8 @@ class BlitPass { | |||
| /// command. | |||
| /// @param[in] slice For cubemap textures, the slice to write | |||
| /// data to. | |||
| /// @param[in] convert_to_read Whether to convert the texture to a shader | |||
There was a problem hiding this comment.
I suppose we can convert this to a UsageHints mask if we need to add more. How about set_read_usage_hint or something similar to indicate this is advisory?
There was a problem hiding this comment.
The odd part is that this isn't advisory for Vulkan, you'll hit an error state if you bind the dest texture without this (assuming you opted out of shader read conversion).
We need a better system for determining layout transitions but I'm not sure what this is right now. Usage hints doesn't feel like the right approach since its a union of possible states and not the current state.
There was a problem hiding this comment.
You mentioned tracking the layouts at the queue level per image once. That seems like a good idea. Have we documented it in an issue?
There was a problem hiding this comment.
Done: flutter/flutter#148698
jonahwilliams
added
the
autosubmit
…148722) flutter/engine@a8fb9da...c2ef01f 2024-05-20 [email protected] Update file permissions for FlutterMacOS.framework (flutter/engine#52930) 2024-05-20 [email protected] [Impeller] leave glyph atlas in transfer dst to improve vulkan throughput. (flutter/engine#52908) 2024-05-20 [email protected] Roll Dart SDK from 54c384453207 to 08f4324c988b (1 revision) (flutter/engine#52931) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
On the vulkan backend everytime we blit a glyph we go shader read -> transfer dst -> shader read. This is pretty inefficient if we're appending many glyphs.
Poke a hole in the blitpass API so we can leave the glyph atlas in transfer_dst to reduce the number of layout transitions.