-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declaring support for Django 5.0 (and Python 3.12)? #265
Labels
enhancement
Enhancement of an existing feature
Comments
Hi there! Vert happy to review a PR indeed. In most cases these version support bumps have been mostly painless. |
florimondmanca
added
help wanted
Extra attention is needed
enhancement
Enhancement of an existing feature
and removed
help wanted
Extra attention is needed
labels
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
djangorestframework-api-key
currently declares Django 4.2 and Python 3.11 as the latest supported versions. Aside from an easily fixable test failure (details below), a localpytest
run suggests that everything works on Django 5.0 and Python 3.12. I'd be happy to submit a PR for these minor changes.Details of minor test failures: three parametrized tests (
tests/test_model.py::test_has_expired
) fail with the following type error:This error is rooted in a change to the default behavior of the
USE_TZ
setting in 5.0. Based on Django's own defaults and recommendations, changing to use timezones by default (inconftest.py
anddateutils.py
) seems reasonable, but settingUSE_TZ
toFalse
also gets tests passing consistently across versions.The text was updated successfully, but these errors were encountered: