Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(size): clip floating width/height to avoid overflowing outside viewport #2896

Merged
merged 2 commits into from
May 15, 2024

Conversation

aicest
Copy link
Contributor

@aicest aicest commented May 14, 2024

To fix #2895.

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: 68551c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@floating-ui/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 14, 2024

Deploy Preview for vibrant-gates-22c214 ready!

Name Link
🔨 Latest commit 68551c0
🔍 Latest deploy log https://app.netlify.com/sites/vibrant-gates-22c214/deploys/66448f8d93947100085e76a7
😎 Deploy Preview https://deploy-preview-2896--vibrant-gates-22c214.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@atomiks
Copy link
Collaborator

atomiks commented May 15, 2024

Thank you! I have noticed this issue before, and it looks like the fix was straightforward

@atomiks atomiks merged commit 25c14b7 into floating-ui:master May 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] size middleware not correctly clipping floating element width/height
2 participants