Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Refactor: Update to esp-idf v.5.0.2 #40

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

WIP: Refactor: Update to esp-idf v.5.0.2 #40

wants to merge 18 commits into from

Conversation

alufers
Copy link

@alufers alufers commented May 28, 2023 •
edited by DrZlo13

Hi!

As you might know the 4.x branch of esp-idf has entered maintenance mode, so only high severity bugs are fixed. It will stop being maintained in 2024, so I've decided to update this project to esp idf v5.0.2.

image

Currently the project compiles under v5.0.2, connects to Wi-Fi but I'm having trouble getting it to actually debug and flash the flipper using my Wifi devboard. I will need to debug it a bit further, but any input from you guys would be appreciated.

Task list:

  • Add components to the REQUIRES argument of idf_component_register
  • Add missing includes
  • Change constants and breaking API changes
  • Use Espressif's tiny usb
  • Add esp-idf component-manager (needed for MDNS and tinyusb)
  • Replace usage of tcpip_adapter_ip_info_t with esp_netif_ip_info_t
  • Change CI
  • Update docs in README.md
  • Test and debug

alufers added 15 commits May 28, 2023 02:10
@alufers
Add required components to blackmagic component
5993a58 
Needed for idf v5.0.2
@alufers
Add required components to dap-link component, add missing include
e012f1c 
Needed for idf v5.0.2. `esp_attr.h` is needed for IRAM_ATTR
@alufers
Add esp_timer.h include to the blackmagic component
22e0ba4
@alufers
Add required components to simple-uart component, add missing include
fe1bd49 
Needed for idf v5.0.2.
@alufers
Add required components to soft-uart component, change include
de5708e 
Needed for idf v5.0.2.
@alufers
change GPIP_PIN_INTR_DISABLE -> GPIO_INTR_DISABLE
ec7c6b4 
Changed for-idf 5.0.2
@alufers
Add esp-idf managed components
d5b601c 
Espressif decided to move the mdns functionality to https://github.com/espressif/esp-protocols,
which is an managed components, so their package manager has to be used.

managed_components has been added to .giitignore, because it is downloaded by esp-idf.
@alufers
Change portTICK_RATE_MS to portTICK_PERIOD_MS
0e87b51 
Changed for esp-idf v5.0.2
@alufers
Rename tinyusb component to usbglue, use esp-idf's tinyusb
1b11ffc 
Renamed the component to avoid conflicts with the esp-idf component. The tinyusb
submodule has been removed and replaced, with Espressif's tinyusb managed component.

Adjusted CMakeLists.txt not to build tinyusb, leave it up to the managed component.

Added missing include to esp_mac.h
@alufers
Add missing includes of esp_chip_info.h and esp_mac.h
fae3a46 
Needed for esp-idf v5.0.2
@alufers
Change usage of nvs_entry_find to suit idf v5.0.2
01b8aef
@alufers
Temporarily remove reading of IP address
6b1c89f 
This has changed in idf v5.0.2, need to rewrite
@alufers
Rewrite functions that obtain the IP addresses to use esp_netif
e9c4ba7
@alufers
Update readme to point to ESP-IDF version v5.0.2
e992956
@alufers
Update CI script
ceabc92
@DrZlo13
Copy link
Member

DrZlo13 commented May 29, 2023

Wow, this is amazing work.

We always wanted to switch to esp-idf v5, but we did not have enough time. We will follow the progress, thanks!

@gautam-dev-maker
Copy link

This PR seems to work fine against IDF VERSION v5.1.1.
I was able to load and flash through gdb over the wifi on my stm32 board.
I am using ESP32S3. I think a sdkconfig.defaults file should be maintained so that this repository will be supported for all the espressif devices.

@augustozanellato
Copy link

augustozanellato commented Feb 1, 2024 •
edited

Any plans on getting this PR rebased and merged?
I'd like to develop new features for the devboard firmware, specifically I was thinking about implementing and RPC<->TCP proxy using the new Expansion Module protocol, and I'd like to know which branch would be better to base my work on.
Thanks in advance :)

@skotopes
Copy link
Member

skotopes commented Feb 1, 2024

@augustozanellato yes we are planning to accept this PR. As soon as all issues with it will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alufers @DrZlo13 @gautam-dev-maker @augustozanellato @skotopes