Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing MySQL master DB based on customer feedback #19075

Merged
merged 10 commits into from
May 23, 2024

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented May 16, 2024

#18838

  1. During software ingestion, switched to updating last_updated_at as a batch for 1 host.
  2. Removed DELETE FROM software statement that ran for every host update (where software was deleted). This is only done now during the vulnerability job.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

@getvictor getvictor force-pushed the victor/18838-additional-db-optimizations branch from 79331fa to ed856f5 Compare May 16, 2024 20:02
@getvictor getvictor marked this pull request as ready for review May 16, 2024 22:10
@getvictor getvictor requested a review from a team as a code owner May 16, 2024 22:10
lucasmrod
lucasmrod previously approved these changes May 22, 2024
Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just one nit comment in the changes/ file.

@getvictor getvictor merged commit 67ab732 into main May 23, 2024
11 of 12 checks passed
@getvictor getvictor deleted the victor/18838-additional-db-optimizations branch May 23, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants