Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add linux platform tuxedo #19011

Merged
merged 1 commit into from
May 29, 2024
Merged

add linux platform tuxedo #19011

merged 1 commit into from
May 29, 2024

Conversation

Andrwe
Copy link
Contributor

@Andrwe Andrwe commented May 15, 2024

Changes

I'm running orbit based osqueryd on a laptop with Tuxedo OS.
This OS identifies its platform via osquery as tuxedo and is therefore not recognized by the Fleet server:

{
    "err": "unrecognized platform",
    "hostID": 76,
    "level": "error",
    "platform": "tuxedo",
    "ts": "2024-05-15T13:17:34.513509387Z"
}

This causes policy and scheduled queries to not being run on my system.
With this PR Im adding tuxedo to all occurrences found when searching for kali.

Additionally pre-commit checks were failing for me locally as it could not find the hook-id RuboCop. This could be solved by using rubocop instead.
Afterwards all pre-commit checks succeeded locally.

Checklist for submitter

  • Added/updated tests

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.74%. Comparing base (5acbfab) to head (072c254).
Report is 4 commits behind head on main.

❗ Current head 072c254 differs from pull request most recent head 593cf68. Consider uploading reports for the commit 593cf68 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19011      +/-   ##
==========================================
- Coverage   66.75%   66.74%   -0.02%     
==========================================
  Files         887      887              
  Lines      108472   108472              
==========================================
- Hits        72415    72395      -20     
- Misses      30177    30190      +13     
- Partials     5880     5887       +7     
Flag Coverage Δ
backend 66.74% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Just a few TODOs:

  • revert the change in .pre-commit.config.yaml
  • Add a file to changes/ e.g. changes/add-tuxedo-os with something like * Added Tuxedo OS to the Linux distribution platform list.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Signed-off-by: Andreas Ulm <[email protected]>
Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(We'll merge the PR as soon as merge freeze window ends.)

Copy link
Contributor

@jacobshandling jacobshandling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving FE since failing tests are result of PR from forked repo – thanks @Andrwe!

@lucasmrod
Copy link
Member

@lukeheath Merging the community PR with CI failures that are most likely due to source being a fork.

@lucasmrod lucasmrod merged commit a8a1054 into fleetdm:main May 29, 2024
11 of 16 checks passed
@jacobshandling
Copy link
Contributor

CI failures that are most likely due to source being a fork.

Pulled down main after merge, confirmed successful build binaries, test-js, and lint-js

@lucasmrod
Copy link
Member

CI failures that are most likely due to source being a fork.

Pulled down main after merge, confirmed successful build binaries, test-js, and lint-js

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants