Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API design: Upload APNs cert and ABM token #18979

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

API design: Upload APNs cert and ABM token #18979

wants to merge 16 commits into from

Conversation

marko-lisica
Copy link
Member

@marko-lisica marko-lisica mentioned this pull request May 14, 2024
Open
10 tasks
roperzh
roperzh reviewed May 20, 2024
View reviewed changes
docs/Contributing/API-for-contributors.md Outdated

`POST /api/v1/fleet/mdm/apple/dep/key_pair`
`GET /api/v1/fleet/mdm/apple/dep/public_key?alt=media`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marko-lisica since we're completely changing this endpoint, would it make sense to move away from dep? the new name is ADE, but maybe we could use automatic like we do for the rest of the endpoints?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roberto Good point, the DEP term is deprecated. I'm looking at the rest of the docs and I think we should go for apple/abm_public_key. This should be the best since this is a public key for ABM and in other endpoints, we always use /apple/... without additional grouping. What do you think?

@roperzh roperzh mentioned this pull request May 21, 2024
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgekarrv georgekarrv georgekarrv left review comments

@roperzh roperzh roperzh left review comments

@jahzielv jahzielv jahzielv left review comments

@rachaelshaw rachaelshaw Awaiting requested review from rachaelshaw rachaelshaw will be requested when the pull request is marked ready for review rachaelshaw is a code owner

@lukeheath lukeheath Awaiting requested review from lukeheath lukeheath will be requested when the pull request is marked ready for review lukeheath is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marko-lisica @georgekarrv @roperzh @jahzielv