add flags to set caching memory manager split+recycling size limits #420
Conversation
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
avidov
force-pushed
the
mem-size-limit-flags
branch
from
a95731a
to
ca11228
Compare
|
@avidov has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
avidov
force-pushed
the
mem-size-limit-flags
branch
from
ca11228
to
34bcd14
Compare
|
@avidov has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Add flags to set configurable limits of the CachingMemoryManager. These flags allow customization for different workloads. This diff changes the default recycling size limit for training to 256MB. Following investigation of OOM on dynamic batching nd based on past allocation analyses we found that this limit works well. Big thanks for WilliamTambellini@ for his work on improving the memory manager capability in handling flexible workload: flashlight#188
avidov
force-pushed
the
mem-size-limit-flags
branch
from
34bcd14
to
cb0d3c7
Compare
|
@avidov has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Hi @avidov! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Add flags to set configurable limits of the CachingMemoryManager. These flags
allow customization for different workloads. This diff changes the default recycling
size limit for training to 256MB. Following investigation of OOM on dynamic batching
nd based on past allocation analyses we found that this limit works well.
Big thanks for WilliamTambellini@ for his work on improving the memory manager
capability in handling flexible workload:
#188
IMPORTANT: Please do not create a Pull Request without creating an issue first. Changes must be discussed.
Original Issue: [corresponding issue on Github]
Note: You can add
closes #[issue number]to automatically close the issue that this PR resolves when it is merged.Summary
[Explain the details for this change and the problem that the pull request solves]
Test Plan (required)
[steps by which you tested that your fix resolves the issue. These might include specific commands and configurations]