-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[logging] throw an exception on LOG(FATAL) instead if calling exit() #208
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
d2f3c1a
to
455ba52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
455ba52
to
77bbf6a
Compare
@avidov has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
77bbf6a
to
35213c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
35213c8
to
c609ade
Compare
@avidov has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
@avidov has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
c609ade
to
d6a9781
Compare
@avidov has updated the pull request. You must reimport the pull request before landing. |
d6a9781
to
04342af
Compare
@avidov has updated the pull request. You must reimport the pull request before landing. |
Hi @avidov! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Summary
Throws an exception containing the logging message on LOG(FATAL).
Test Plan (required)
[steps by which you tested that your fix resolves the issue. These might include specific commands and configurations]