Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update deployment.yaml for embedded DB option #1767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

connected-me
Copy link

@connected-me connected-me commented Apr 2, 2024

Appears to by resolved as of 1.0.258, though an upgrade in place does not seem to resolve.

Helm chart release version(s): 1.0.257 - 1.0.258-beta.9
Issue:
Enbedded postgres server created with:
postgres using /opt/database/bin/bin/pg_ctl start -w -D /opt/database/data -o -p 6432:

URL previously pointed to /opt/database/ causing crash reboot

Steps to recreate:
use the following values.yaml with the above versions

db:
  runMigrations: true
  embedded:
  # If the database is embedded, setting this to true will persist the contents of the database
  # through a persistent volume
    persist: true
    storageClass: ""
    storage: 20Gi

Suggestions:
update default embedded database URL to /opt/database/data

update default embedded database URL
created with:
postgres using /opt/database/bin/bin/pg_ctl start -w -D /opt/database/data -o -p 6432:

URL previously pointed to /opt/database/ causing crash reboot
@CLAassistant
Copy link

CLAassistant commented Apr 2, 2024

CLA assistant check
All committers have signed the CLA.

@connected-me connected-me changed the title Update deployment.yaml fix: Update deployment.yaml for embedded DB option Apr 2, 2024
@moshloop
Copy link
Member

moshloop commented Apr 4, 2024

Hi @connected-me - Thanks for the contribution - We are in the process of setting up some helm tests (which should expose this issue) after which we can merge

@yashmehrotra yashmehrotra self-assigned this Apr 4, 2024
@yashmehrotra
Copy link
Member

@connected-me When I set it up using the helm chart

helm install canary-checker flanksource/canary-checker -n "canary-checker"  --create-namespace

it worked out of the box for me

Can you share your exact setup steps so that we can reproduce it

@connected-me
Copy link
Author

connected-me commented Apr 4, 2024

@connected-me When I set it up using the helm chart

helm install canary-checker flanksource/canary-checker -n "canary-checker"  --create-namespace

it worked out of the box for me

Can you share your exact setup steps so that we can reproduce it

edit: looks like it has been fixed in the most recent version already, can be disregarded.

Will update the initial request but when including the values.yaml in the previous version (updated in initial comment) with the following settings

db:
  runMigrations: true
  embedded:
    # If the database is embedded, setting this to true will persist the contents of the database
    # through a persistent volume
    persist: true
    storageClass: "<your storage class>"
    storage: 20Gi

It's also possible that it doesn't chmod the folder to 0700 or 0750 but didn't want to dive too far down the rabbit hole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants