Make sure lsame_ is exported
#82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reference (netlib) LAPACK implementation exports `lsame_` unconditionally. When trying to use libflame as a drop-in replacement for the reference implementation on Windows, programs fail to start with an error that the symbol `lsame_` is undefined. IIUC, that is because the symbol resolution is done on link time for Windows (instead of at runtime on most other platforms). The proposed change makes sure that `lsame_` is exported from libflame even if configured with `--disable-lapack2flame --disable-builtin-blas` (the default). IIUC, an alternative would be to export this symbol defined in `src/flablas/f2c/lsame.c`. But the proposed change is a bit closer to the reference implementation. See also this downstream report: https://savannah.gnu.org/bugs/index.php?63184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference (netlib) LAPACK implementation exports
lsame_unconditionally. When trying to use libflame as a drop-in replacement for the reference implementation on Windows, programs fail to start with an error that the symbollsame_is undefined. IIUC, that is because the symbol resolution is done on link time for Windows (instead of at runtime on most other platforms).The proposed change makes sure that
lsame_is exported from libflame even if configured with--disable-lapack2flame --disable-builtin-blas(the default).IIUC, an alternative would be to export this symbol defined in
src/flablas/f2c/lsame.c. But the proposed change is a bit closer to the reference implementation.See also this downstream report: https://savannah.gnu.org/bugs/index.php?63184