Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Docker image used for compiling artificial samples #454

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Improve Docker image used for compiling artificial samples #454

merged 3 commits into from
Apr 3, 2024

Conversation

vobst
Copy link
Collaborator

@vobst vobst commented Apr 2, 2024

Some small improvements to the final image:

  • smaller size (ignore artifacts)
  • faster rebuild time (reordering of steps)
  • better interactive usage (chown to user)

Enkelmann
Enkelmann approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@Enkelmann Enkelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as long as the CI also agrees.

@vobst vobst force-pushed the improve-docker-image-artificial_samples branch from 86b5d5e to f64ad83 Compare April 3, 2024 07:42
@vobst vobst merged commit 7297cd5 into fkie-cad:master Apr 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enkelmann Enkelmann Enkelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vobst @Enkelmann