Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set leveledlogger for the pkg retryablehttp #2769

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saltbo
Copy link
Contributor

@saltbo saltbo commented Apr 4, 2023

Description

set leveledlogger for the pkg retryablehttp

Which issue(s) this PR fixes:

Fixes #2768

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #2769 (4456ddb) into main (1cbc0ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2769   +/-   ##
=======================================
  Coverage   20.84%   20.84%           
=======================================
  Files          68       68           
  Lines        7344     7344           
=======================================
  Hits         1531     1531           
  Misses       5699     5699           
  Partials      114      114           
Flag Coverage Δ
unittests 20.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shubham-bansal96
Copy link
Contributor

@saltbo
CI test is failing for your changes. Please check.

@saltbo
Copy link
Contributor Author

saltbo commented May 8, 2023

@saltbo CI test is failing for your changes. Please check.

I have not found failed cause with this PR, can you help me retry to trigger it?

@shubham-bansal96
Copy link
Contributor

@saltbo CI test is failing for your changes. Please check.

I have not found failed cause with this PR, can you help me retry to trigger it?

Could you please rebase your branch from main ?

@saltbo saltbo force-pushed the bugfix/clientlog branch 2 times, most recently from 3326d2a to baa4e29 Compare May 10, 2023 01:14
@saltbo
Copy link
Contributor Author

saltbo commented May 11, 2023

I can't find why failed for the integration-test, the log is too long...

can you help me to look at it? @shubham-bansal96

@sanketsudake
Copy link
Member

sanketsudake commented May 17, 2023

We typically export kubernetes logs in kind-logs.

https://github.com/fission/fission/actions/runs/4932062313?pr=2769#artifacts

All fission services logs can be noticed here.

I have also written small utility to speedup analysis
https://github.com/fission/fission/blob/main/hack/dump-analyzer.md

@shubham-bansal96 can you please check logs ? We may need to retrigger build.

@sanketsudake
Copy link
Member

sanketsudake commented May 18, 2023

Can you please rebase with latest main ?

@saltbo saltbo closed this May 22, 2023
@saltbo saltbo deleted the bugfix/clientlog branch May 22, 2023 01:56
@saltbo saltbo restored the bugfix/clientlog branch May 22, 2023 06:09
@saltbo saltbo reopened this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is always a DEBUG-level log in the router log
3 participants