completions/insmod: Add support for insmod command #10410
Conversation
This commit introduces a new completion script for the `insmod` command, enabling Fish shell users to autocomplete file for `.ko` (kernel module) files in the current directory.
| function _insmod_complete | ||
| # List all .ko files in the current directory for completion. | ||
| for file in (ls *.ko) | ||
| echo $file |
There was a problem hiding this comment.
This for-loop is broken in a number of ways:
lscan take optionsls *is duplicating work - we already know that the given files exist once the glob matches- It only works in the current directory and won't complete paths (like e.g. "/lib/modules/foo/", which you very likely want to do)
- The entire loop is unnecessary, you can just do
printf '%s\n' *.ko
But mostly, this is duplicating __fish_complete_suffix .ko. Just use that, remove the entire function.
There was a problem hiding this comment.
Hi faho, thanks for your quick reply.
It only works in the current directory and won't complete paths (like e.g. "/lib/modules/foo/", which you very likely want to do)
IMO "/lib/modules/foo/" can be left for modprobe, insmod is more commonly used to insert a ko in the local directory. Including /lib/modules for insmod seems somewhat overhead(at least to me).
But mostly, this is duplicating __fish_complete_suffix .ko. Just use that, remove the entire function.
Thanks for your tip! But I encounter an issue:
complete -c insmod -a "(__fish_complete_suffix .ko)" -f
This doesn't work somehow and TAB still lists all files, could you please provide some insights? Thanks.
There was a problem hiding this comment.
IMO "/lib/modules/foo/" can be left for modprobe, insmod is more commonly used to insert a ko in the local directory. Including /lib/modules for insmod seems somewhat overhead(at least to me).
I see no reason to not support directories.
This doesn't work somehow and TAB still lists all files, could you please provide some insights? Thanks.
__fish_complete_suffix will complete all files, but leave matching ones at the top.
This is because the suffix is not actually authoritative - you can name files whatever you want.
This is a very common problem when people try to complete e.g. ".txt" files, and then notice that they have a lot of text files with another or no suffix. For modules specifically, you may find ".ko" files, but they can also be compressed - ".ko.gz".
What you want is
complete -c insmod -a "(__fish_complete_suffix .ko)" -kfwhere the "-k" tells "complete" to not sort the completions but keep the order they're in.
Description
This commit introduces a new completion script for the
insmodcommand, enabling Fish shell users to autocomplete file for.ko(kernel module) files in the current directory.