Fix periodicity function to also work with numeric multipliers as occasionally attached by pandas. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzietlow
force-pushed
the
f/also_infer_numeric_frequencies
branch
from
7db71b2
to
38fe44e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #14 and also encapsulates the proposed changes from #16.
Pandas (depending on your time series) attaches numerical values before the base frequency, e.g. "5T", meaning a five minute frequency.
This is now reflected by scaling the intended frequency down accordingly, e.g. instead of a 60-unit periodicity => a 60/5 -> 12-unit periodicity is now assumed.