Crashlytics dispatch Rollouts writes async to prevent hangs #12977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
approved these changes
May 16, 2024
visumickey
reviewed
May 16, 2024
visumickey
approved these changes
May 17, 2024
paulb777
approved these changes
May 17, 2024
|
We have a ton of flakes in Crashlytics... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12913 reports hangs writing to rollouts.
I was able to reproduce this in a test by putting a long running operation on the
FIRCLSGetLoggingQueue(). Root cause is dispatching synchronously for writes to rollouts.Added a test case to ensure
updateRolloutsStateToPersistenceWithRolloutsreturns to the caller without blocking on the dispatch queue.