Fix: whereField creates a memory leak #12972
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #12613
revert the thread safe memoizer introduced in this pr: #11781
@cherylEnkidu :
This PR intends to fix the data race and memory leak issue.
When using memorized field, it leads to data race. However, the solution for fixing data race issue introduces memory leak.
So this PR construct a flatten filters for composite filter during initialization.
The reason for not providing
GetFlattenFilter()
in base filter class is creating flatten filter in field filter constructor will cause infinity loop.Since
GetFlattenFilter()
is widely used in query calls, initflatten filters vector
in composite filter during construction won't hurt efficiency a lot comparing to constructflatten filters vector
upon request.