Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediately close realtime connections when in background #5819

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qdpham13
Copy link
Contributor

Immediately close realtime connections when in background

Copy link
Contributor

github-actions bot commented Mar 28, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-config

    Overall coverage changed from 84.11% (c9fa461) to 84.13% (47d73f0) by +0.02%.

    FilenameBase (c9fa461)Merge (47d73f0)Diff
    ConfigAutoFetch.java87.74%87.85%+0.11%
    ConfigRealtimeHttpClient.java68.93%69.08%+0.15%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/njzmdHJW3l.html

Copy link
Contributor

Unit Test Results

  40 files   -    102    40 suites   - 102   1m 9s ⏱️ - 2m 11s
310 tests  -    766  310 ✔️  -    766  0 💤 ±0  0 ±0 
632 runs   - 1 520  632 ✔️  - 1 520  0 💤 ±0  0 ±0 

Results for commit abd35ab. ± Comparison against base commit c9fa461.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-config

    TypeBase (c9fa461)Merge (47d73f0)Diff
    aar109 kB109 kB+176 B (+0.2%)
    apk (aggressive)265 kB265 kB+68 B (+0.0%)
    apk (release)4.81 MB4.81 MB+80 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uFrF1HoRM2.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-rc

    DeviceStatisticsDistributions
    oriole-32
    Percentilec9fa46147d73f0DiffSignificant (?)
    p10154 ±125 μs207 ±407 μs+53.2 μs (+34.6%)NO
    p25162 ±132 μs226 ±451 μs+64.2 μs (+39.6%)NO
    p50177 ±145 μs248 ±497 μs+71.1 μs (+40.3%)NO
    p75208 ±159 μs283 ±549 μs+74.6 μs (+35.8%)NO
    p90264 ±207 μs331 ±611 μs+66.4 μs (+25.1%)NO

    20 test runs in comparison
    CommitTest Runs
    c9fa461
    • 2024-03-28_17:00:25.053717_JmeA
    • 2024-03-28_17:00:25.053748_cePf
    • 2024-03-28_17:00:25.053755_sAIj
    • 2024-03-28_17:00:25.053759_QWJR
    • 2024-03-28_17:00:25.053767_PwxY
    • 2024-03-28_17:00:25.053777_pZaO
    • 2024-03-28_17:00:25.053786_XFhQ
    • 2024-03-28_17:00:25.053793_HcFz
    • 2024-03-28_17:00:25.053800_eSGg
    • 2024-03-28_17:00:25.053807_LCRx
    47d73f0
    • 2024-03-28_23:06:11.056105_hdtM
    • 2024-03-28_23:06:11.056142_VpAY
    • 2024-03-28_23:06:11.056154_MEPQ
    • 2024-03-28_23:06:11.056163_basl
    • 2024-03-28_23:06:11.056170_CpuN
    • 2024-03-28_23:06:11.056177_GYQV
    • 2024-03-28_23:06:11.056185_aGbd
    • 2024-03-28_23:06:11.056191_LYIj
    • 2024-03-28_23:06:11.056198_gHdI
    • 2024-03-28_23:06:11.056205_yvTx
    redfin-30
    Percentilec9fa46147d73f0DiffSignificant (?)
    p10335 ±467 μs332 ±479 μs-2.93 μs (-0.9%)NO
    p25386 ±556 μs377 ±572 μs-8.84 μs (-2.3%)NO
    p50475 ±675 μs428 ±666 μs-47.5 μs (-10.0%)NO
    p75575 ±821 μs507 ±820 μs-68.4 μs (-11.9%)NO
    p90764 ±1028 μs579 ±924 μs-185 μs (-24.2%)NO

    20 test runs in comparison
    CommitTest Runs
    c9fa461
    • 2024-03-28_17:00:25.053717_JmeA
    • 2024-03-28_17:00:25.053748_cePf
    • 2024-03-28_17:00:25.053755_sAIj
    • 2024-03-28_17:00:25.053759_QWJR
    • 2024-03-28_17:00:25.053767_PwxY
    • 2024-03-28_17:00:25.053777_pZaO
    • 2024-03-28_17:00:25.053786_XFhQ
    • 2024-03-28_17:00:25.053793_HcFz
    • 2024-03-28_17:00:25.053800_eSGg
    • 2024-03-28_17:00:25.053807_LCRx
    47d73f0
    • 2024-03-28_23:06:11.056105_hdtM
    • 2024-03-28_23:06:11.056142_VpAY
    • 2024-03-28_23:06:11.056154_MEPQ
    • 2024-03-28_23:06:11.056163_basl
    • 2024-03-28_23:06:11.056170_CpuN
    • 2024-03-28_23:06:11.056177_GYQV
    • 2024-03-28_23:06:11.056185_aGbd
    • 2024-03-28_23:06:11.056191_LYIj
    • 2024-03-28_23:06:11.056198_gHdI
    • 2024-03-28_23:06:11.056205_yvTx
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilec9fa46147d73f0DiffSignificant (?)
    p10199 ±2 ms202 ±2 ms+2.90 ms (+1.5%)NO
    p25204 ±3 ms208 ±2 ms+4.05 ms (+2.0%)NO
    p50212 ±2 ms215 ±2 ms+3.25 ms (+1.5%)NO
    p75219 ±3 ms222 ±2 ms+3.11 ms (+1.4%)NO
    p90227 ±4 ms232 ±4 ms+5.14 ms (+2.3%)NO

    20 test runs in comparison
    CommitTest Runs
    c9fa461
    • 2024-03-28_17:00:25.053717_JmeA
    • 2024-03-28_17:00:25.053748_cePf
    • 2024-03-28_17:00:25.053755_sAIj
    • 2024-03-28_17:00:25.053759_QWJR
    • 2024-03-28_17:00:25.053767_PwxY
    • 2024-03-28_17:00:25.053777_pZaO
    • 2024-03-28_17:00:25.053786_XFhQ
    • 2024-03-28_17:00:25.053793_HcFz
    • 2024-03-28_17:00:25.053800_eSGg
    • 2024-03-28_17:00:25.053807_LCRx
    47d73f0
    • 2024-03-28_23:06:11.056105_hdtM
    • 2024-03-28_23:06:11.056142_VpAY
    • 2024-03-28_23:06:11.056154_MEPQ
    • 2024-03-28_23:06:11.056163_basl
    • 2024-03-28_23:06:11.056170_CpuN
    • 2024-03-28_23:06:11.056177_GYQV
    • 2024-03-28_23:06:11.056185_aGbd
    • 2024-03-28_23:06:11.056191_LYIj
    • 2024-03-28_23:06:11.056198_gHdI
    • 2024-03-28_23:06:11.056205_yvTx
    redfin-30
    Percentilec9fa46147d73f0DiffSignificant (?)
    p10249 ±11 ms269 ±4 ms+20.2 ms (+8.1%)NO
    p25255 ±12 ms275 ±5 ms+20.0 ms (+7.9%)NO
    p50262 ±13 ms282 ±6 ms+19.8 ms (+7.6%)NO
    p75270 ±14 ms290 ±7 ms+20.8 ms (+7.7%)NO
    p90278 ±14 ms302 ±10 ms+24.5 ms (+8.8%)NO

    20 test runs in comparison
    CommitTest Runs
    c9fa461
    • 2024-03-28_17:00:25.053717_JmeA
    • 2024-03-28_17:00:25.053748_cePf
    • 2024-03-28_17:00:25.053755_sAIj
    • 2024-03-28_17:00:25.053759_QWJR
    • 2024-03-28_17:00:25.053767_PwxY
    • 2024-03-28_17:00:25.053777_pZaO
    • 2024-03-28_17:00:25.053786_XFhQ
    • 2024-03-28_17:00:25.053793_HcFz
    • 2024-03-28_17:00:25.053800_eSGg
    • 2024-03-28_17:00:25.053807_LCRx
    47d73f0
    • 2024-03-28_23:06:11.056105_hdtM
    • 2024-03-28_23:06:11.056142_VpAY
    • 2024-03-28_23:06:11.056154_MEPQ
    • 2024-03-28_23:06:11.056163_basl
    • 2024-03-28_23:06:11.056170_CpuN
    • 2024-03-28_23:06:11.056177_GYQV
    • 2024-03-28_23:06:11.056185_aGbd
    • 2024-03-28_23:06:11.056191_LYIj
    • 2024-03-28_23:06:11.056198_gHdI
    • 2024-03-28_23:06:11.056205_yvTx

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wjlPrrHG14/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants