fix(auth): fail gracefully when no cache headers are available #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
changed the title
DellaBitta
reviewed
May 22, 2024
auth/token_verifier.go
Outdated
| @@ -476,19 +473,20 @@ func parsePublicKey(kid string, key []byte) (*publicKey, error) { | |||
| return &publicKey{kid, pk}, nil | |||
| } | |||
|
|
|||
| func findMaxAge(resp *http.Response) (*time.Duration, error) { | |||
| func findMaxAge(resp *http.Response) *time.Duration { | |||
| duration := time.Duration(0) * time.Second | |||
There was a problem hiding this comment.
Can this line go with the default return value at the bottom of the function?
There was a problem hiding this comment.
Thanks! Moved the default value to the bottom
hsubox76
approved these changes
May 22, 2024
DellaBitta
approved these changes
May 22, 2024
Xiaoshouzi-gh
approved these changes
May 22, 2024
Yeah, the integrations tests are all green! |
lahirumaramba
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #621
Avoid throwing errors when parsing cache control headers for public keys and set the cache duration to 0 (equivalent to no cache) when the cache headers cannot be parsed.