Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloud inconsistencies #36

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Conversation

TheUnderScorer
Copy link
Contributor

No description provided.

@TheUnderScorer TheUnderScorer self-assigned this Apr 20, 2023
@TheUnderScorer TheUnderScorer changed the base branch from main to develop April 20, 2023 07:05
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
60% (-0.91% 🔻)
321/535
🔴 Branches
48.72% (-1.28% 🔻)
57/117
🟡 Functions
62.14% (-1.23% 🔻)
64/103
🟡 Lines
60.31% (-0.94% 🔻)
313/519
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / IntegrationError.ts
0% 100% 0% 0%

Test suite run success

61 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 7ea3077

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟡 All files 60 48.71 62.13 60.3
🟡  management 58.78 58.33 84.61 58.78
🟢   config.ts 100 100 100 100
🔴   env.ts 0 0 0 0 3-23
🟢   github.ts 100 71.42 100 100 44,57
🟢   healthCheck.ts 97.05 75 100 97.05 83
🔴   index.ts 0 0 0 0 2-121
🟢   rollback.ts 100 100 100 100
🟡   semver.ts 80 100 100 80 7
🟢   settings.ts 100 100 100 100
🟢   site.ts 100 80 100 100 47
🟢   storage.ts 100 100 100 100
🟡  proxy/customer-variables 52.63 50 40 56.86
🟡   CustomerVariables.ts 78.94 0 100 77.77 26,44-52
🔴   EnvCustomerVariables.ts 0 0 0 0 3-9
🟢   defaults.ts 100 100 100 100
🟢   maybeObfuscateVariable.ts 100 100 100 100
🔴   selectors.ts 0 100 0 0 2-22
🟢   types.ts 100 100 100 100
🟢  proxy/domain 83.83 50 100 83.15
🟢   tld.ts 83.83 50 100 83.15 74,87,124,135-141,148,172,188,194,198,202,217,227
🔴  proxy/errors 0 100 0 0
🔴   IntegrationError.ts 0 100 0 0 1-7
🔴  proxy/handlers 0 0 0 0
🔴   agent.ts 0 0 0 0 2-89
🔴   ingress.ts 0 0 0 0 2-88
🔴   status.ts 0 0 0 0 3-130
🟢  proxy/utils 97.36 88.88 100 97.29
🟢   cacheControl.ts 100 100 100 100
🟢   cookies.ts 100 100 100 100
🟢   errorResponse.ts 100 100 100 100
🟢   headers.ts 94.11 85 100 93.87 84-90
🟢   routing.ts 100 100 100 100
🟢   traffic.ts 100 100 100 100

export async function downloadAgent({ httpRequest, logger }: DownloadAgentParams) {
const DEFAULT_VERSION = '3'

export async function downloadAgent({ httpRequest, logger, path }: DownloadAgentParams) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the return type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@sshelomentsev sshelomentsev merged commit 37fc809 into develop Apr 25, 2023
2 checks passed
@ilfa ilfa deleted the bugfix/cloud-inconsistency branch December 1, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants