Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ci INTER-353 #18

Merged
merged 24 commits into from
Nov 8, 2023
Merged

chore: add ci INTER-353 #18

merged 24 commits into from
Nov 8, 2023

Conversation

Orkuncakilkaya
Copy link
Contributor

@Orkuncakilkaya Orkuncakilkaya commented Oct 30, 2023

Deployed URL:

https://chore-ci.cfi-fingerprint.com (You should bypass ssl errors to view)

@Orkuncakilkaya Orkuncakilkaya marked this pull request as draft October 30, 2023 11:52
@Orkuncakilkaya Orkuncakilkaya marked this pull request as ready for review November 6, 2023 11:20
@necipallef
Copy link
Contributor

Can we replace all mentions of cfi-fingerprint.com with a GitHub secret, @Orkuncakilkaya ?

@necipallef
Copy link
Contributor

necipallef commented Nov 6, 2023

After PR is merged, the DNS record and Akamai property still stays, right? We probably should clean it up. This could be in another PR because this PR is already big enough. @Orkuncakilkaya

Edit: On a second thought, maybe we just delete the DNS record. Akamai doesn't let us delete a property with a DNS record, and it will take some time for DNS record to be completely deleted from the internet. I think the GH action just deletes the DNS record, and we delete the Akamai property manually later.

@Orkuncakilkaya
Copy link
Contributor Author

I thought about implementing a way to clear property and DNS record but the thing is, when you try to delete property Akamai gives this warning "Can't delete property because X domain has CNAME to it". When I tried to delete DNS record and retry to delete property I still got the same error, probably Akamai caches the result for CNAMEs. Even if we have an automation to delete properties, it can't run successfully. But we can implement a way to delete DNS record on Cloudflare.

Copy link

github-actions bot commented Nov 7, 2023

This PR will not create a new release 🚀

@necipallef necipallef merged commit dbaf6f3 into main Nov 8, 2023
2 checks passed
@necipallef necipallef deleted the chore/ci branch November 8, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants