fix cache-control response header honoring for browser cache endpoint and immutable
honoring for Pro CDN
#17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: There is a problem with the browser cache endpoint's response. The
Cache-Control
header is not propagated as-is to the browser. It should beCache-Control: max-age=31534000, immutable, private
but it isCache-Control: max-age=0, no-cache, no-store
, and also the response hasPragma: no-cache
which shouldn't have.The solution has two steps:
Pragma
header. This also fixes the problem withmax-age
andprivate
, butimmutable
flag is still missing.immutable
flag. Add this behavior also to the ProCDN rule since it may be needed in the future.