fix: async validating #473
Conversation
xxleyi
force-pushed
the
fix-async-validating
branch
from
eb22c35
to
72c9d73
Compare
|
Hi @xxleyi , can you please add a test that fails prior to your change and passes afterwards? Thus we can ensure we have no regression of the same issue in the future |
|
@gertdreyer Test has already been provided by @iamdey in react-final-form, final-form/react-final-form#1018. I tried and it worked well. |
|
Can you include that test in the automated testing? |
|
@gertdreyer these are two repo, you mean I include that test in final-form? |
|
It should be possible to do it in a vanilla JS test in this repo - if you want to attempt that, otherwise, I am happy to merge as is due to the existing bug examples and tests being in RFF. |
|
@gertdreyer I don't have many experience on JS test, so maybe merge firstly? I will try add test later. |
|
@gertdreyer Sorry to bother, I added test PR #475, and we are still meeting this problem, can we publish a new version? |
try fix final-form/react-final-form#780