[WIP] Fix bug with incorrect errors for nested fields #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrin4869
force-pushed
the
nested-field-level-validation-bugfix
branch
from
9ea1b69
to
ebd3318
Compare
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 555 557 +2
Branches 115 116 +1
=====================================
+ Hits 555 557 +2
Continue to review full report at Codecov.
|
|
I can confirm this bug also affects me. I didn't test your solution but it looks like it can solve this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress, but I would appreciate your input.
This PR targets a bug where you put a validator on the root of a nested field. Let's say you want to ensure a range is valid. Assert that
range.min < range.maxby setting a validator onrange. This is required, if for example, you have an array of ranges (as in our case).The error message gets converted to an object with keys.
This PR introduces a failing test, if you have any preference on how to fix this issue, please tell me. Otherwise I can come up with a solution.
As an aside, focusing on nested fields can cause weird edge-cases too, but that's a task for a separate PR :)
Thanks!