New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update poseidon.md #1276

Open

jbaylina wants to merge 1 commit into filecoin-project:master from jbaylina:patch-1

jbaylina commented Oct 7, 2021

Original reference: lurk-lab/neptune#113
@DrPeterVanNostrand

The documentation says that w is the first column of m_hat or second column of m without the first row..

Actually it is the first column of m without the first row.

The implementation is ok: https://github.com/filecoin-project/neptune/blob/bafd77a5014e3b6a6b40359097835c3eb1dd533f/src/mds.rs#L197


Update poseidon.md

1d813b3

Original reference: lurk-lab/neptune#113

The documentation says that w is the first column of m_hat or second column of m without the first row.. 

Actually it is the first column of m   without the first row.

The implementation is ok: https://github.com/filecoin-project/neptune/blob/bafd77a5014e3b6a6b40359097835c3eb1dd533f/src/mds.rs#L197

DrPeterVanNostrand mentioned this pull request

fix: Poseidon spec's sparse-factorization w vector #1278

Open

Contributor

DrPeterVanNostrand commented Oct 7, 2021

Thanks @jbaylina! There is a duplicate of this PR here #1278 which in addition contains a small update to sparse_factorization's documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment