Add prop for height ration derived from calculated width of cropper container #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a strange feature that might not need for most people. Thanks for your work, but I will not merge this at this moment. |
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 72.63% 72.69% +0.05%
==========================================
Files 9 9
Lines 1535 1538 +3
==========================================
+ Hits 1115 1118 +3
Misses 420 420
Continue to review full report at Codecov.
|
fengyuanchen
force-pushed
the
main
branch
5 times, most recently
from
cb5ac44
to
aa96a51
Compare
fengyuanchen
force-pushed
the
main
branch
2 times, most recently
from
a367d75
to
3375ce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
My use case, I have a placeholder for cropper, what has absolute position in percentages. v1.5.9 fit the cropper container to the width, bud height is not calculate properly and it is derived from the image. But I need keep same placeholder ratio without any dependency and size of viewport. So I add possibility to set this ratio and it works great. Usage is optional, of course.