Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo deny in CI #538

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Use cargo deny in CI #538

wants to merge 5 commits into from

Conversation

Plecra
Copy link

@Plecra Plecra commented Feb 8, 2022

Status

  • Ready
  • Development
  • Hold

Description

As mentioned in #531 (comment), I've setup the repo to use cargo deny. It is now correctly checking everything, and allowing for a set of exceptions in deny.toml.

All that's left is adding a workflow for running the tool.

Related issues

Leave empty if none

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

@Iaiao
Copy link
Contributor

Iaiao commented Feb 8, 2022

quill is licensed under Apache 2.0 or MIT

@Plecra
Copy link
Author

Plecra commented Feb 8, 2022

Right, I was surprised about that :) I couldn't find an explicit mention of the MIT license in the repo - where is Apache+MIT declared?

@Iaiao
Copy link
Contributor

Iaiao commented Feb 8, 2022

There are quill/LICENSE-APACHE and quill/LICENSE-MIT. There's no explicit mention of dual licensing in README.md and Cargo.toml though, so I'm not sure about that. @caelunshun is quill dual licensed, or why is there 2 license files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants