Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background check #31

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

perellonieto
Copy link


name: Pull Request
about: Template for pull requests


Description

Please explain what features the pull request implements and/or changes made.

Reason behind implementation

Does this pull request link to an existing feature request or a bug report? If so please provide a link and/or the issue number.

Are there any other branches related to this work?

If there are any branches related to this work please provide the branch name and link.

Example code

# If possible please provide us with a small amount of code using the features implemented
# in this pull request.

Checklist

Please ensure you have done every task in this checklist.

  • Created any additional unit tests required.
  • All tests pass.
  • Code style is consistent with the project.
  • No additional Python packages except NumPy and SciPy are required.
  • The code is documented.
  • Appropriate API documentation, tutorials, how-to guides and user guide entries were created.

@perellonieto
Copy link
Author

I have added a Jupyter Notebook example that needs to be revised.

https://github.com/perellonieto/fat-forensics/blob/background_check/background_check_example.ipynb

fatf/accountability/models/background_check.py Outdated Show resolved Hide resolved
fatf/accountability/models/background_check.py Outdated Show resolved Hide resolved
fatf/accountability/models/background_check.py Outdated Show resolved Hide resolved
fatf/accountability/models/background_check.py Outdated Show resolved Hide resolved
fatf/accountability/models/background_check.py Outdated Show resolved Hide resolved
Copy link
Author

@perellonieto perellonieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have amended all the requested changes.

- dotted line represents 2D plot
- option for default mu0 and m1
- show classifier decision boundary
- show background
- Added question point in all the plots
- Changes in buttons to make it more intuitive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants