Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circleci #3

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Circleci #3

wants to merge 6 commits into from

Conversation

alexhepburn
Copy link
Collaborator

Added CircleCI config.yml file in order to run pytest for python versions 2.7, 3.6 & 3.7. Codecov tests are also ran with python 3.6.

Copy link
Contributor

@mattclifford1 mattclifford1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Token for codecov needs adding when we obtain one.

Unsure if .pytest_cache is needed or not?

. venv/bin/activate
py.test --cov-report xml
pytest --cov=./ --cov-report xml
codecov --token= INPUT TOKEN HERE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rememeber to add token once we have one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to generate a token by our Monday meeting (since we take the development private for the time being

@So-Cool
Copy link
Member

So-Cool commented Sep 21, 2018

requirements.txt Outdated
@@ -1,2 +1,3 @@
numpy>=1.8.2
scipy>=0.13.3
pytest>=3.7.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we need a separate requirements.txt file for development/ developers. You only need pytest if you want to develop the package and not if you want to use it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check how it is done in other packages.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's needed as long as in the continuous integration tools we specify to install pytest, codecov and pytest-cov.
One way around this is to have a requirements directory which has requirements.txt and requirements-dev.txt in. Then in the base directory you would have requirements.txt which specifies to use the normal requirements, then with devs you would just do

pip install -r requirements/requirements-dev.txt

This way the normal command still works for non devs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. This will be resolved by #5.

@So-Cool
Copy link
Member

So-Cool commented Sep 21, 2018

I think you're right. .pytest_cache/README.md says that none of the files in the .pytest_cache directory should be committed to version control so we need to add this path to .gitignore. Please double check that and let us know what is the purpose of the .pytest_cache directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants