-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circleci #3
base: dev
Are you sure you want to change the base?
Circleci #3
Conversation
…with 'test_'. The testing is performed by pytest. Also added pytest to requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Token for codecov needs adding when we obtain one.
Unsure if .pytest_cache is needed or not?
. venv/bin/activate | ||
py.test --cov-report xml | ||
pytest --cov=./ --cov-report xml | ||
codecov --token= INPUT TOKEN HERE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rememeber to add token once we have one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to generate a token by our Monday meeting (since we take the development private for the time being
requirements.txt
Outdated
@@ -1,2 +1,3 @@ | |||
numpy>=1.8.2 | |||
scipy>=0.13.3 | |||
pytest>=3.7.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we need a separate requirements.txt
file for development/ developers. You only need pytest
if you want to develop the package and not if you want to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check how it is done in other packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's needed as long as in the continuous integration tools we specify to install pytest, codecov and pytest-cov.
One way around this is to have a requirements directory which has requirements.txt and requirements-dev.txt in. Then in the base directory you would have requirements.txt which specifies to use the normal requirements, then with devs you would just do
pip install -r requirements/requirements-dev.txt
This way the normal command still works for non devs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. This will be resolved by #5.
I think you're right. |
539adac
to
bb6fd18
Compare
Added CircleCI config.yml file in order to run pytest for python versions 2.7, 3.6 & 3.7. Codecov tests are also ran with python 3.6.