Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve env vars instructions #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

revolter
Copy link
Collaborator

No description provided.

Copy link
Member

@mollyIV mollyIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @revolter 👋 ,

I really like your PR and I think it will simplify a development process for issue-bot project 🙌

Recently we added a feature, where a bot sends a notification to Slack channel if pinned issue is closed: #63. I just noticed, that after this change, when we type bundle exec rake --tasks without having GITHUB_API_TOKEN ENV exported, we get the error 😿

Though your PR can be a good place to improve the docs for this case too.

What I would suggest is to move your new instructions about source .keys at the very top:

# Development

## Pre-requirements

1. create a `.keys` file containing:

export FASTLANE_ISSUE_BOT_SLUG="<github-username>/<repo-name>"
export GITHUB_API_TOKEN="<github-token>"
export ACTION_CHANNEL_SLACK_WEB_HOOK_URL="https://hooks.slack.com/services/<slack-hook-id>"

2. run `source .keys`

## Commands // didn't have better idea for this title, we can totally improve it
You can use rake to easily run a couple of tasks.
...

WDYT?

If you have no time working on that, I would be happy to take over and help 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants