Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Digest::MD5.file instead of Digest::MD5.hexdigest #21999

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reflexing
Copy link

@reflexing reflexing commented May 2, 2024

Fixes #20527

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

fastlane fails to upload large .pkg and crashes. I know nothing about Ruby, but apparently ruby can't handle loading large file at once. MD5.file allows successful package upload.
Resolves #20527

Description

I'm just trying to set up our CI pipeline.

Testing Steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading .pkg mac binaries to testflight failing
1 participant